Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in various files #2407

Merged
merged 4 commits into from
Dec 7, 2024
Merged

Fix typos in various files #2407

merged 4 commits into from
Dec 7, 2024

Conversation

crStiv
Copy link
Contributor

@crStiv crStiv commented Nov 22, 2024

Why is this change needed?

This pull request fixes multiple typos across several files in the repository to enhance code clarity and maintainability. Correcting these typos improves the readability of the code and prevents potential confusion for contributors and maintainers.

Summary of Changes

  1. apps/hubble/src/network/p2p/connectionFilter.ts

    • Fixed typo: deiniedPeersdeniedPeers.
  2. apps/hubble/src/network/sync/merkleTrie.test.ts

    • Fixed typo: unloadChidrenAtRootunloadChildrenAtRoot.
  3. apps/hubble/src/network/sync/merkleTrie.ts

    • Fixed typos: unloadChidrenAtRootunloadChildrenAtRoot.
  4. apps/hubble/src/network/sync/multiPeerSyncEngine.test.ts

    • Fixed typo in comment: coundcount.

Merge Checklist


Allow edits by maintainers:

Appreciate your time and review!


PR-Codex overview

This PR focuses on correcting typographical errors in method names and comments across multiple files, enhancing code clarity and maintainability.

Detailed summary

  • Corrected method name from unloadChidrenAtRoot to unloadChildrenAtRoot in merkleTrie.ts and its test file.
  • Fixed parameter name from deiniedPeers to deniedPeers in the constructor of connectionFilter.ts.
  • Corrected the spelling of "count" in a comment in multiPeerSyncEngine.test.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

"deiniedPeers" to "deniedPeers"
"chidren" to "children"
"chidren" to "children"
Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: 74c0632

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 6:48pm

@sds sds merged commit 3ae1c71 into farcasterxyz:main Dec 7, 2024
4 checks passed
@sds sds added the t-docs Add or update documentation label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-docs Add or update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants